Update triplea_maps.yaml

[VictoryFirst2]

Update img links and description of World War I 1914 Balanced and Improved/Tournament Rules.

[beelee1]

Hi Victory

When you update the yaml, you need to change the version as well. It uses whole numbers, so version 2 is what you want.

I've never seen 2 maps in the same PR but I don't see anything wrong with it.

[VictoryFirst2]

@beelee1 But I didn't make any changes to the map, only to the description. Do I need to change the version number for that too?

[beelee1]

Yea, anytime the yaml is changed the version needs to change.

Edit
The yaml version and the map version aren't usually the same. The yaml version is basically just for the yaml.

[Cernelius]

@beelee1 But I didn't make any changes to the map, only to the description. Do I need to change the version number for that too?

Yea, anytime the yaml is changed the version needs to change.

Edit The yaml version and the map version aren't usually the same. The yaml version is basically just for the yaml.

Can you give me a link to the documentation for this process?

If he did not change anything in the map itself, I do not understand why a version upgrade is needed, because that would tell users to update the map with a new map which is the same as the one they already have.

[beelee1]

I don't know it for certain. It's just what I remember being told. You'd have to ask one of the devs. Last time I merged a yaml that wasn't correct, it messed up the entire lobby and Roi had to fix it, so I'm not gonna do it until someone says it's ok or they do it themselves.

Edit
The yaml PR is what tells people there is a new map version. If one doesn't want a new version, then the PR should be closed. The changes to the map have already taken place. Once the repo is updated, the next time that map is DL'd, you will get the latest version.

Edit 2
The PR should be made at this repo https://github.com/triplea-maps/world-war-i-1914-improved-main
Once it is accepted, it will automatically be updated without notifying anyone of an update.

If you want to notify people of an update, then you need to change the yaml version.

[frigoref]

@VictoryFirst2 @beelee1 Is this still a valid PR or can it be closed? Note that there are conflicts now.

[beelee1]

@frigoref I would close it since never heard back. It can be resubmitted in the future if he wants

[Cernelius]

@VictoryFirst2 @beelee1 Is this still a valid PR or can it be closed? Note that there are conflicts now.

So can the download description be changed without updating the number if the map has not been changed? I would not update the number either. This issue is practically waiting for this to be answered positively (merging) or negatively (closing). This beside the conflicts I don't know.

[beelee1]

@Cernelius yea no answer on the yaml number change. I guess should leave it open then. Also on whether people other than the map owner can update it. The yaml.

No change to the map except the description, which is a change imo. Can anybody do that ? I wouldn't like it being done to maps that I uploaded originally without my knowledge/approval.