Skip to content
This repository was archived by the owner on Mar 17, 2024. It is now read-only.

Allow xlabel to be decribed with "Node" HTML like element #148

Conversation

tokidrill
Copy link
Contributor

@tokidrill tokidrill commented Jul 15, 2020

What was a problem

The label can describe HTML Like with React, but the xlabel is not supported.

How this PR fixes the problem

  • Add property "xlabel" to props of NodeProps
  • Add tests

Check lists (check x in [ ] of list items)

  • Test passed
  • Coding style (indentation, etc)

Extra contexts

@kamiazya kamiazya added the enhancement New feature or request label Jul 16, 2020
@kamiazya kamiazya self-requested a review July 16, 2020 08:13
@kamiazya
Copy link
Member

@tokidrill
Regarding the granularity of the release, I think that we will do it at the same time because there is no sense of uniformity in the API unless we also support Edge.

It would be helpful if support for Edge could be included in this PR.

@kamiazya kamiazya linked an issue Jul 16, 2020 that may be closed by this pull request
@kamiazya kamiazya merged commit 4b44134 into ts-graphviz:master Feb 10, 2021
@kamiazya
Copy link
Member

@all-contributors please add @tokidrill for code, tests.

@allcontributors
Copy link
Contributor

@kamiazya

I've put up a pull request to add @tokidrill! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow xlabel to be described in HTML Like.
2 participants