Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@tus/gcs-store: require @google-cloud/storage ^7 #735

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Murderlon
Copy link
Member

This is to split the breaking change out of #616 so that PR can land anything without needing a breaking change.

@Murderlon Murderlon added the Breaking change This requires a semver major release label Mar 12, 2025
@Murderlon Murderlon self-assigned this Mar 12, 2025
Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: 53f54fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tus/gcs-store Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Mar 12, 2025

Walkthrough

This pull request introduces a new changeset file that documents a major version update for the @tus/gcs-store package and specifies that @google-cloud/storage is now required as a peer dependency at version 7. Additionally, the package’s configuration in the package.json file is updated so that both devDependencies and peerDependencies reference the newer version (^7.15.2) of the @google-cloud/storage package.

Changes

File(s) Change Summary
.changeset/little-pets-unite.md, packages/gcs-store/package.json • Added a new changeset file documenting a major update for @tus/gcs-store and specifying @google-cloud/storage@7 as a peer dependency.
• Updated @google-cloud/storage in package.json: changed devDependencies from ^6.12.0 to ^7.15.2 and peerDependencies from * to ^7.15.2.

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 274a0d1 and 53f54fa.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .changeset/little-pets-unite.md (1 hunks)
  • packages/gcs-store/package.json (2 hunks)
🔇 Additional comments (3)
packages/gcs-store/package.json (2)

26-26: Dev Dependency Version Update Verified

The version for @google-cloud/storage in devDependencies has been updated to ^7.15.2, which meets the PR objective. Please ensure that all relevant tests pass with this updated dependency version and verify that there are no regressions related to the new version’s API changes.


35-35: Peer Dependency Version Update Confirmed

The peerDependencies entry for @google-cloud/storage is now set to ^7.15.2, enforcing the required compatibility for downstream consumers. This change is aligned with the breaking change intended in the PR. Please double-check that this version constraint does not conflict with other parts of the ecosystem using this package.

.changeset/little-pets-unite.md (1)

1-6: Changeset File for Major Version Update Confirmed

The changeset file clearly documents a major version update for the @tus/gcs-store package and specifies that @google-cloud/storage@7 is now required as a peer dependency. This documentation effectively communicates the breaking change and aligns with the updated dependency versions in package.json.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@google-cloud/storage@6.12.07.15.2 Transitive: network +79 6.1 MB google-wombot

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change This requires a semver major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant