-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Astro to version 3 #457
Conversation
Will never be used again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very, very much for this PR!
**:warning: Please be aware that the uploaded files will be removed from our | ||
servers after a few hours, for privacy, and to combat people uploading malicious | ||
content.** | ||
**<Emoji label="warning">⚠️</Emoji> Please be aware that the uploaded files will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all emojis be wrapped in this element now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome Nick! Just a few minor questions about this
All good here! Can be merged as soon as the merge conflict is resolved imo |
# Conflicts: # yarn.lock
Thank you very much, Nick! |
Taking it one major at a time. This PR:
remark-emoji
, it was only used for two emojis. Instead, force emoji's to color emoji's using system-default color emoji font families where needed, or use Unicode emoji's.is:inline
to some script tags)