Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Astro to version 3 #457

Merged
merged 15 commits into from
Jul 19, 2024
Merged

Upgrade Astro to version 3 #457

merged 15 commits into from
Jul 19, 2024

Conversation

nickrttn
Copy link
Contributor

Taking it one major at a time. This PR:

  • upgrades Astro to v3 and Astro plugins to versions matching Astro v3.
  • updates the config accordingly
  • removes a script that was used when migrating from Jekyll to Astro and will never be used again
  • sets the default formatter for Astro files to the VS Code Astro plugin
  • removes remark-emoji, it was only used for two emojis. Instead, force emoji's to color emoji's using system-default color emoji font families where needed, or use Unicode emoji's.
    • this package also has mismatching types with the upgraded Astro, and so removing it was the easiest route considering it was already fairly heavy-handed for the two emoji's we were using it for.
  • fixes linting errors that were the result of the upgrade (eg. adding is:inline to some script tags)

@nickrttn nickrttn requested review from kvz, Acconut and Murderlon July 12, 2024 10:27
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very, very much for this PR!

**:warning: Please be aware that the uploaded files will be removed from our
servers after a few hours, for privacy, and to combat people uploading malicious
content.**
**<Emoji label="warning">⚠️</Emoji> Please be aware that the uploaded files will
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all emojis be wrapped in this element now?

Copy link
Member

@kvz kvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Nick! Just a few minor questions about this

@kvz
Copy link
Member

kvz commented Jul 15, 2024

All good here! Can be merged as soon as the merge conflict is resolved imo

@nickrttn nickrttn merged commit 3c9ffe9 into tus:main Jul 19, 2024
1 check passed
@nickrttn nickrttn deleted the astro3 branch July 19, 2024 08:23
@Acconut
Copy link
Member

Acconut commented Jul 19, 2024

Thank you very much, Nick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants