Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ iOS tutorials RxCocoa version up #368

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

ElonPark
Copy link
Contributor

@ElonPark ElonPark commented Feb 14, 2020

Description:
ios/tutorials Update dependency
pod 'RxCocoa', '~> 4.0.0' -> pod 'RxCocoa', '~> 5.1'

@ElonPark ElonPark requested a review from kovpas February 14, 2020 15:40
@ElonPark ElonPark changed the title ⬆️ RxCocoa version up ⬆️ iOS tutorials RxCocoa version up Feb 14, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@kovpas
Copy link
Contributor

kovpas commented May 8, 2020

Hey @ElonPark, thanks for the contribution! Could you please rebase so Travis could build the changes? Also, please update version to 5.1 - the same as main RIBs library is using. Thanks!

@ElonPark
Copy link
Contributor Author

ElonPark commented May 8, 2020

Hey @ElonPark, thanks for the contribution! Could you please rebase so Travis could build the changes? Also, please update version to 5.1 - the same as main RIBs library is using. Thanks!

OK, no problem

@ElonPark ElonPark force-pushed the dev branch 2 times, most recently from 5e95c9f to 3ac3493 Compare May 8, 2020 18:03
@kovpas
Copy link
Contributor

kovpas commented May 8, 2020

Thanks a lot @ElonPark! 👍

@kovpas kovpas merged commit ffc489f into uber:master May 8, 2020
ryo-otake-sonix pushed a commit to ryo-otake-sonix/RIBs that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants