Skip to content

fix wrong nsu Encoding #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

fix wrong nsu Encoding #124

merged 5 commits into from
Apr 14, 2025

Conversation

Kantiran91
Copy link
Member

The encoding of the nodeid of a machine in the topic tree caused problems in the topic structure of the mqtt. This PR fix it.

@Kantiran91 Kantiran91 requested a review from mdornaus April 9, 2025 15:03
@Kantiran91 Kantiran91 linked an issue Apr 9, 2025 that may be closed by this pull request
@GoetzGoerisch
Copy link
Member

rebase please

@Kantiran91 Kantiran91 requested review from GoetzGoerisch and removed request for mdornaus April 14, 2025 12:08
@Kantiran91 Kantiran91 force-pushed the fix/wrongNSUEncoding branch from 77a71b0 to bd1d684 Compare April 14, 2025 12:16
@Kantiran91
Copy link
Member Author

@GoetzGoerisch Feature is ready and tested. Can you please review/approve so we can close it.

@Kantiran91
Copy link
Member Author

rebase please

done - but I suggest "squash and merge"

@GoetzGoerisch GoetzGoerisch merged commit 7b98057 into develop Apr 14, 2025
15 of 16 checks passed
@GoetzGoerisch GoetzGoerisch deleted the fix/wrongNSUEncoding branch April 14, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeId is not escaped correctly
2 participants