-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support insert route #698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
+ Coverage 51.74% 52.42% +0.67%
==========================================
Files 64 64
Lines 1546 1568 +22
Branches 403 425 +22
==========================================
+ Hits 800 822 +22
+ Misses 744 737 -7
- Partials 2 9 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
路由插入场景还需要做一下前置检查,必须符合这个条件,即 route 自身的 path 必须是 target 对应的 path 的子路由,不然直接 throw error,如
// 这里的 target path 必须是 /user 或者 /,如果是 /abc 这种直接抛异常,因为 /user/test 无法成为 /abc 的子路由
{ path: '/user/test', microApp: 'abc', target: '/user' }
6b823a4
to
efe9a4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat: insert route