Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change pandas engine to be numpy>2 compat #1690

Merged
merged 27 commits into from
Jun 20, 2024
Merged

change pandas engine to be numpy>2 compat #1690

merged 27 commits into from
Jun 20, 2024

Conversation

cosmicBboy
Copy link
Collaborator

@cosmicBboy cosmicBboy commented Jun 17, 2024

fixes #1656

This PR:

  • Updates the pandas/numpy type engine to stop using deprecated numpy types
  • Updates CI to run the extras packages in a separate job
  • Moves extra package (pyspark, dask, modin, etc) out of the top-level module-loading execution path of pandera
  • Pins numpy<2 in extra package CI
  • Adds a temporary numpy2 patch until dependent packages (pyspark, modin, etc) support numpy2
  • Disables decimal type test for modin
  • Pins numpy<2 in readthedocs config yaml

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
@cmarshak
Copy link

Thank you for fixing this!

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
@cosmicBboy cosmicBboy merged commit 47c236e into main Jun 20, 2024
154 checks passed
@cosmicBboy cosmicBboy deleted the bugfix/1656 branch June 20, 2024 14:13
@kr-hansen kr-hansen mentioned this pull request Jun 25, 2024
max-raphael pushed a commit to max-raphael/pandera that referenced this pull request Jan 24, 2025
* change pandas engine to be numpy>2 compat

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* remove numpy from mypy pre-commit type stubs

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* install numpy<2.0.0 in readthedocs build

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* remove check docs ci test

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* update

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* debug

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* update requirements

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* update requirements, only use numpy2 for latest pandas

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* move pyspark config

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* remove typing from root __init__

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* [wip] try patching numpy2 with NaN

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* [wip] remove pyspark import from typing.pandas

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* isolate dask, modin, pyspark, etc imports, update ci

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* update numpy patch

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* fix ci numpy pin

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* update ci

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* update

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* update

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* debug

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* debug

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* debug

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* update ci test for mypy

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* add numpy patch to root pandera

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* debug

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* debug

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* debug

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

* skip modin test for decimals, remove pandas2.0.3

Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>

---------

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: cosmicBboy <niels.bantilan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandera not compatible with numpy 2.0
2 participants