Skip to content

S U I #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 78 commits into
base: main
Choose a base branch
from
Open

S U I #4549

wants to merge 78 commits into from

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented May 13, 2025

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview May 30, 2025 2:21pm

@aeryz aeryz force-pushed the sui-stuff branch 3 times, most recently from 87a9b7e to b08897e Compare May 19, 2025 19:06
@aeryz aeryz marked this pull request as ready for review May 19, 2025 19:06
@aeryz aeryz requested a review from benluelo as a code owner May 19, 2025 19:06
@aeryz aeryz requested a review from hussein-aitlahcen as a code owner May 21, 2025 11:14
benluelo and others added 22 commits May 30, 2025 16:09
@benluelo @aeryz
chore: trigger ci
cba9f8e
@aeryz
chore(sui): plenty of voyager stuff
14f68a1 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore: more sui
d578255 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): initiate the light client
f6d5609 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): add more tx and events to voyager
a038f6a 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore: add base58 encoding
195864c 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(sui): sui contents digest calculation works
e7feac0 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(sui): signature verification works
2a0729d 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): proper serde bincode feature gating
23e6e64 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): tons of stuff, so tired
f5b890b 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): moar stuff
b69c62a 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): a step towards membership
81111b2 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): add transaction types
78f1da4 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): properly calculate the object digest
5fdba73 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): figure out how to hash transactioneffects
5d151ab 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(sui): add checkpoint verifier
aeecaed 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): verifier continues
66a0ec2 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): proof generated omg
64b70b0 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): moar
02e0c1e 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): proofs work
96eea5c 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): cleanup before merge
88fcc79 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): more refactoring
3cc65ec 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
aeryz and others added 24 commits May 30, 2025 16:14
@aeryz
chore(sui): god sui works
947a1e1 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): refactor galois a bit
cc2e1c3 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): try the new port structure
56246ae 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): fix
a89e7a5 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): add module info to voyager tx info
c0e12bf 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): change port parsing
cae2128 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): moar fix
b6a3949 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): add portid to channel open txs
3034ec9 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): fix port parsing
c851d9d 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): fix event parse
6a74b97 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
chore(sui): fixed packet.data issue
bfcdd77 
Signed-off-by: Kaan Caglan <caglankaan@gmail.com>
@Caglankaan @aeryz
chore(sui): fixed source-destination mismatch issue
4071618 
Signed-off-by: Kaan Caglan <caglankaan@gmail.com>
@Caglankaan @aeryz
chore(sui): fixed channel issue in process_receive
f8ab335 
Signed-off-by: Kaan Caglan <caglankaan@gmail.com>
@aeryz
chore(galois): clean up bls proving stuff
81634eb 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): bunch of improvements
ef3d7ac 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
chore(sui): added channel_balance function to zkgm
9d71f88 
Signed-off-by: Kaan Caglan <caglankaan@gmail.com>
@aeryz
chore(sui): refactor channel handshake entirely
6806af7 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): fix send and recv packets
ff977c9 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): fix recv,send and ack
5d47f30 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): better port parsing
9b160c5 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): adding token registry to voyager
cc4c906 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(sui): register tokens
50831fd 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore: fmt
17b66d0 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
chore(sui): removed unnecessary events
984d252 
Signed-off-by: Kaan Caglan <caglankaan@gmail.com>
Caglankaan and others added 4 commits May 30, 2025 16:56
@Caglankaan
chore(sui): fixed all warnings in zkgm
7c53f9f 
Signed-off-by: Kaan Caglan <caglankaan@gmail.com>
@aeryz
chore(sui): moar
9e6e73f 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan
chore(sui): fixed last warning
8e0b259 
Signed-off-by: Kaan Caglan <caglankaan@gmail.com>
@aeryz
chore: fix sui voyager modules
8e40937 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
aeryz
aeryz commented May 30, 2025
View reviewed changes
Cargo.toml
"voyager/modules/client/trusted-mpt",

"voyager/modules/client-bootstrap/bob",
# "voyager/modules/client-bootstrap/bob",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment

Cargo.toml

"voyager/plugins/client-update/bob",
# "voyager/plugins/client-update/bob",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment

galoisd/cmd/galoisd/cmd/example_prove.go
@@ -210,7 +210,7 @@ func ExampleProveCmd() *cobra.Command {
},
}

res, err := client.Prove(ctx, &req)
res, err := client.ProveBls12381(ctx, &req)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this support both

galoisd/cmd/galoisd/cmd/query_stats.go
@@ -16,7 +16,7 @@ func QueryStats() *cobra.Command {
Use: "query-stats [uri]",
Args: cobra.ExactArgs(1),
RunE: MakeCobra(func(ctx context.Context, client provergrpc.UnionProverAPIClient, cmd *cobra.Command, args []string) error {
res, err := client.QueryStats(ctx, &provergrpc.QueryStatsRequest{})
res, err := client.QueryStatsBls12381(ctx, &provergrpc.QueryStatsRequest{})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this support both

galoisd/go.mod
@@ -152,7 +152,8 @@ replace (
replace (
github.com/cometbft/cometbft => github.com/unionlabs/cometbls v0.0.0-20241021101406-df0586cc2041
github.com/cometbft/cometbft/api => github.com/unionlabs/cometbls/api v0.0.0-20241021101406-df0586cc2041
github.com/consensys/gnark => github.com/unionlabs/gnark v0.0.0-20240723153903-9d859afe4c14
// github.com/consensys/gnark => github.com/unionlabs/gnark v0.0.0-20240723153903-9d859afe4c14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

voyager/plugins/transaction/sui/Cargo.toml
ucs03-zkgm = { workspace = true, features = ["library"] }
unionlabs = { workspace = true }
voyager-sdk = { workspace = true }
voyager-vm = { workspace = true }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

voyager/plugins/transaction/sui/src/main.rs

#[tokio::main(flavor = "multi_thread")]
async fn main() {
// let sui_client = SuiClientBuilder::default()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

voyager/plugins/transaction/sui/src/main.rs

let mut bytecode = TOKEN_BYTECODE[0].to_vec();
bytecode.extend_from_slice(&hex!(
"0000000000000000000000000000000000000000000000000000000000000001"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be the decimal value

voyager/plugins/transaction/sui/src/main.rs
.next()
.expect("sender has a gas token");

let gas_budget = 200_000_000; //TODO: change it later
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to be configurable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe calculate idk?

voyager/plugins/transaction/sui/src/main.rs
panic!("invalid port id");
}

let upgrade_cap_address: SuiAddress = module_info[2].parse().unwrap();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluelo benluelo Awaiting requested review from benluelo benluelo is a code owner

@hussein-aitlahcen hussein-aitlahcen Awaiting requested review from hussein-aitlahcen hussein-aitlahcen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aeryz @benluelo @Caglankaan