Skip to content

feat(loader): support load config failure option #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ysknsid25
Copy link
Contributor

resolves #234

Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
@ysknsid25 ysknsid25 requested a review from pi0 April 2, 2025 10:26
@ysknsid25 ysknsid25 force-pushed the feature/inspect-resolved-config branch from f13bf72 to b83895e Compare April 2, 2025 11:05
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
@ysknsid25 ysknsid25 force-pushed the feature/inspect-resolved-config branch from 9ada132 to 74c0a7f Compare April 2, 2025 11:43
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
Signed-off-by: ysknsid25 <kengo071225@gmail.com>
@pi0
Copy link
Member

pi0 commented Apr 2, 2025

Thanks for preparing PR.

I might need time to locally test everything before merge and release of it but current implementation looks good 👍🏼

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.10%. Comparing base (42d9697) to head (c67ce2a).
Report is 123 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
- Coverage   76.92%   73.10%   -3.82%     
==========================================
  Files           7        8       +1     
  Lines         806      647     -159     
  Branches       80      114      +34     
==========================================
- Hits          620      473     -147     
+ Misses        184      172      -12     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ysknsid25
Copy link
Contributor Author

@pi0
Thanks for the review!! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option to fail if config not exists
2 participants