-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fix balanceOf #3147
WIP: fix balanceOf #3147
Conversation
@@ -225,6 +221,7 @@ contract('Lock / erc721 / transferFrom', accounts => { | |||
from, | |||
}) | |||
ID = await locks['FIRST'].getTokenIdFor.call(from) | |||
console.log(ID) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HardlyDifficult ID at this point is 0, but should actually be a valid tokenID!
D0 we need to "wait" for mining before querying the contract perhaps?
@HardlyDifficult I'm stuck on this atm...here's the latest build log. https://circleci.com/gh/unlock-protocol/unlock/46868?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link As you can see, 2 failing tests. The second one is I need to take a break from this, it's killing me. If you know what's going on here off the top of your head, well that would be swell. |
That second error, 'out of gas', is because of the first error. So that's the one to focus on. hmm I'm not sure which line is failing though - wish the stack trace didn't suck =p. Maybe add some console logs to narrow it down |
Yeah the stack trace does suck. Ive been playing with adding console.logs, as well as commenting out lines, to try to isolate the failure. Will keep at it after a break. |
@nfurfaro fixed the gas report - sorry for the trouble. not exactly sure how it was working previously ;) |
@HardlyDifficult Thanks! I wasn't sure what was causing that error, but happy to move on! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Description
This is just a start in the right direction. Still have some work to do to get tests passing again.
Issues
Fixes #3089
Checklist: