-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install note manual-install-method.md #254
base: main
Are you sure you want to change the base?
Conversation
I was caught out by the wrong partition type, and took some time to figure it out
WalkthroughThe documentation for the manual installation of Unraid OS has been updated. A new instruction clarifies that users must select the MBR/MS-DOS partition table when formatting the USB flash drive. This update is added to prevent issues with modern partitioning tools that default to GPT, ensuring compatibility with the installation process. No changes have been made to the exported or public entities. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/unraid-os/getting-started/manual-install-method.md (1)
15-16
: Clear and Essential Addition of Partition Table GuidanceThe new instruction clearly informs users that they must select the MBR/MS-DOS partition table type, explicitly warning that many modern tools default to GPT—which would cause the installation process (e.g., the
make_bootable_linux
command) to fail. This change directly addresses the issues raised in the PR description.Suggestion: Consider adding a brief note about the potential failure (or error message) if GPT is inadvertently selected. This additional context could further help users understand the criticality of choosing the correct partition table type.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/unraid-os/getting-started/manual-install-method.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: AWS Amplify Console Web Preview
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary
I was caught out by the wrong partition table type, and took some time to figure it out. I'm running on Fedora, so couldn't use the new USB creator tool that is a debian binary. Updated the "important" section to specify the partition table type.
Without following this step, running
make_bootable_linux
fails on its pre-flight checks.Summary by CodeRabbit