Fix resolving of endpoint #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove .net framework * add .net8 * Added support for multiple ODP instances * Refactoring; adding logging * Refactoting and logging
|
Hi @stefanolsen, can you look at this PR again, the commits look wrong. |
|
@andrewmarkham You are right. Opening a new PR (#20). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't use a specific endpoint, and would instead need the first endpoint, nothing is selected.
This is because the first in list is only selected if
endpointKeyis null. However, inStandardPrefixerthe default isstring.Empty.This PR changes the default value to null, to enable the mentioned logic. Besides this, the PR also makes the Regex expression static to highlight its singleton nature.