Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client.enabled property. #721

Merged
merged 2 commits into from
Mar 16, 2025
Merged

Add client.enabled property. #721

merged 2 commits into from
Mar 16, 2025

Conversation

jheer
Copy link
Member

@jheer jheer commented Mar 16, 2025

  • Add client enabled property. When enabled is set to false, the client will not initialize nor respond to query requests and selection updates. This setting can improve performance, for example by suppressing updates to off-screen interface components. When enabled is set to true, any pending initialization or query requests will then proceed.
  • Add enabled option to makeClient helper utility.
  • Refactor initialization logic between coordinator and client.
  • Add tests for client enabled property.

@jheer jheer requested a review from domoritz March 16, 2025 15:38
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I suppose this will help with #461.

I am a bit concerned about the name. An active selection/clause means it's the last interacted with but an active client means it's a client that is enabled. Maybe that's okay but as an alternative, we could call it enabled. I don't feel strongly about it, though.

@jheer
Copy link
Member Author

jheer commented Mar 16, 2025

I prefer enabled as well. I'll make that change, then merge!

@jheer jheer changed the title Add client active property. Add client enabled property. Mar 16, 2025
@jheer jheer changed the title Add client enabled property. Add client.enabled property. Mar 16, 2025
@jheer jheer merged commit 93e9235 into main Mar 16, 2025
3 checks passed
@jheer jheer deleted the jh/client-active branch March 16, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants