Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop client fields and fieldInfo methods, use prepare instead. #722

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

jheer
Copy link
Member

@jheer jheer commented Mar 17, 2025

This PR simplifies and streamlines the client lifecycle to use a single prepare call as part of client initialization. It includes the breaking change of removing the Mosaic client field and fieldInfo lifecycle methods. Instead of these methods, clients can directly call mosaic-core's queryFieldInfo within a client's prepare lifecycle method.

  • Breaking: Drop client fields and fieldInfo lifecycle methods, rely solely on prepare instead. The queryFieldInfo can be used instead to lookup field info directly; it uses the same types as the removed methods.
  • Update inputs and plot package to call queryFieldInfo within the client prepare method.

@jheer jheer requested a review from domoritz March 17, 2025 04:17
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this simplification. Makes sense!

@jheer jheer merged commit 718b48e into main Mar 17, 2025
3 checks passed
@jheer jheer deleted the jh/prepare branch March 17, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants