Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to changelog in gemspec #845

Merged
merged 5 commits into from
Feb 25, 2025
Merged

Link to changelog in gemspec #845

merged 5 commits into from
Feb 25, 2025

Conversation

eizengan
Copy link
Contributor

@eizengan eizengan commented Jan 31, 2025

A well-kept changelog should be showcased! Could alternatively indent everything a little further and add a few of these; whatever your preference

gem.metadata["key"] = "value"

To do

  • I have read the contributing guidelines.
  • I have added relevant tests.
  • I have adjusted relevant documentation.
  • I have made sure the individual commits are meaningful.
  • I have added relevant lines to the CHANGELOG.

PS: Thank you for contributing to Pundit ❤️

@Burgestrand
Copy link
Member

TIL about the other metadata keys: https://docs.ruby-lang.org/en/3.4/Gem/Specification.html#attribute-i-metadata

Thank you 🙂

@Burgestrand
Copy link
Member

The test failures here are unrelated! I'll have a look at them in another branch and fix this PR up, and then merge once that's done 😄

@eizengan
Copy link
Contributor Author

eizengan commented Feb 11, 2025

Sounds good! Want me to add any of the other keys in that metadata? Happy to do the work, but don't want to put words in your mouth a-la "GitHub issues is our official bug tracker"

EDIT: decided to ask forgiveness not permission; other links added to the best of my ability

@Burgestrand
Copy link
Member

Looks great! You made the right choice 🙂

@Burgestrand
Copy link
Member

Test failure is unrelated to this PR in a sense. Or rather, I think the particular failure isn't all too useful in the gemspec. I'll make some adjustments to rubocop 🙂

@Burgestrand Burgestrand merged commit cbaa0ab into varvet:main Feb 25, 2025
12 of 13 checks passed
@Burgestrand
Copy link
Member

Thanks! I made a few semi-related changes while I was fixing the overall build, and now it's merged! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants