-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link to changelog in gemspec #845
Conversation
TIL about the other metadata keys: https://docs.ruby-lang.org/en/3.4/Gem/Specification.html#attribute-i-metadata Thank you 🙂 |
The test failures here are unrelated! I'll have a look at them in another branch and fix this PR up, and then merge once that's done 😄 |
Sounds good! Want me to add any of the other keys in that metadata? Happy to do the work, but don't want to put words in your mouth a-la "GitHub issues is our official bug tracker" EDIT: decided to ask forgiveness not permission; other links added to the best of my ability |
Looks great! You made the right choice 🙂 |
Test failure is unrelated to this PR in a sense. Or rather, I think the particular failure isn't all too useful in the gemspec. I'll make some adjustments to rubocop 🙂 |
Thanks! I made a few semi-related changes while I was fixing the overall build, and now it's merged! |
A well-kept changelog should be showcased! Could alternatively indent everything a little further and add a few of these; whatever your preference
To do
PS: Thank you for contributing to Pundit ❤️