Skip to content

add version check for codeql-actions #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Apr 3, 2025

Description

  • fix version check for codeql actions
  • run local
$ git -c pager.diff='less -R' diff versions/actions
diff --git a/versions/actions/GITHUB_CODEQL_ACTION_ANALYZE b/versions/actions/GITHUB_CODEQL_ACTION_ANALYZE
index 0e5b3f69f..e74ce3140 100644
--- a/versions/actions/GITHUB_CODEQL_ACTION_ANALYZE
+++ b/versions/actions/GITHUB_CODEQL_ACTION_ANALYZE
@@ -1 +1 @@
-2.20.7
+3.28.13
diff --git a/versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD b/versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD
index 0e5b3f69f..e74ce3140 100644
--- a/versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD
+++ b/versions/actions/GITHUB_CODEQL_ACTION_AUTOBUILD
@@ -1 +1 @@
-2.20.7
+3.28.13
diff --git a/versions/actions/GITHUB_CODEQL_ACTION_INIT b/versions/actions/GITHUB_CODEQL_ACTION_INIT
index 0e5b3f69f..e74ce3140 100644
--- a/versions/actions/GITHUB_CODEQL_ACTION_INIT
+++ b/versions/actions/GITHUB_CODEQL_ACTION_INIT
@@ -1 +1 @@
-2.20.7
+3.28.13
diff --git a/versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF b/versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF
index 0e5b3f69f..e74ce3140 100644
--- a/versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF
+++ b/versions/actions/GITHUB_CODEQL_ACTION_UPLOAD_SARIF
@@ -1 +1 @@
-2.20.7
+3.28.13

Related Issue

Versions

  • Vald Version: v1.7.16
  • Go Version: v1.24.2
  • Rust Version: v1.85.1
  • Docker Version: v28.0.4
  • Kubernetes Version: v1.32.3
  • Helm Version: v3.17.2
  • NGT Version: v2.3.14
  • Faiss Version: v1.10.0

Checklist

Special notes for your reviewer

Summary by CodeRabbit

Below are the high-level updates in this release:

  • Chores
    • Updated our integration management to refine how version details are determined, applying different methods based on integration type for improved reliability.
    • Enhanced flexibility for external requests by adding configurable options, offering more adaptable operations.

These changes are part of our ongoing efforts to optimize system performance.

Copy link
Contributor

coderabbitai bot commented Apr 3, 2025

📝 Walkthrough

Walkthrough

This PR updates the logic in the update-github-actions function within the Makefile. The change introduces a case statement to determine whether to fetch the version from the tags endpoint for github/codeql-action related actions or to use the existing latest release logic for other actions. Additionally, it modifies the curl command to include a pagination parameter for retrieving the most recent tag.

Changes

File(s) Change Summary
Makefile.d/functions.mk Modified the version retrieval logic in update-github-actions to use a case statement for checking action names. Introduced a condition for github/codeql-action actions to fetch version from tags instead of the latest release. Updated curl command to include ?per_page=1 for pagination.

Sequence Diagram(s)

sequenceDiagram
    participant U as update-github-actions
    participant C as Curl Command
    participant API as GitHub API

    U->>U: Check action name
    alt Action is github/codeql-action variant
        U->>C: Execute curl with pagination for tags endpoint
        C->>API: Request most recent tag
    else
        U->>C: Execute curl for latest release endpoint
        C->>API: Request latest release
    end
    API-->>C: Return version information
    C-->>U: Pass version information back
Loading

Possibly related PRs

  • Update Actions dependency #2623: The changes in this PR modify the logic for determining the version of GitHub actions, which relates to the retrieved PR that updates the version numbers of specific GitHub actions, particularly those starting with github/codeql-action.

Suggested labels

actions/backport/release/v1.7

Suggested reviewers

  • kpango
  • vankichi

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2371fc and e45ad72.

📒 Files selected for processing (1)
  • Makefile.d/functions.mk (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Makefile.d/functions.mk

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2025

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions github-actions bot added area/makefile size/S type/bug Something isn't working labels Apr 3, 2025
@kmrmt kmrmt requested review from a team, kpango and vankichi and removed request for a team April 3, 2025 05:32
coderabbitai[bot]
coderabbitai bot previously approved these changes Apr 3, 2025
Copy link

cloudflare-workers-and-pages bot commented Apr 3, 2025

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: e45ad72
Status: ✅  Deploy successful!
Preview URL: https://6329c71a.vald.pages.dev
Branch Preview URL: https://bugfix-makefile-codeql-versi.vald.pages.dev

View logs

vankichi
vankichi previously approved these changes Apr 3, 2025
@kmrmt kmrmt dismissed stale reviews from vankichi and coderabbitai[bot] via e45ad72 April 3, 2025 07:32
@vankichi vankichi merged commit 1572e83 into main Apr 4, 2025
217 of 238 checks passed
@vankichi vankichi deleted the bugfix/makefile/codeql-version-check branch April 4, 2025 05:18
vdaas-ci pushed a commit that referenced this pull request Apr 4, 2025
* add version check for codeql-actions

* fix
vankichi pushed a commit that referenced this pull request Apr 4, 2025
* add version check for codeql-actions

* fix

Co-authored-by: Kosuke Morimoto <ksk@vdaas.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants