Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AboutStringBuilder - Mismatched Variables #367

Closed
ghost opened this issue Mar 3, 2020 · 3 comments
Closed

AboutStringBuilder - Mismatched Variables #367

ghost opened this issue Mar 3, 2020 · 3 comments
Labels
Category-Koans Invoking the Great Doubt Good First Issue ❇️ Should be quick and easy! Issue-Bug 🐛 Something's wrong! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it.

Comments

@ghost
Copy link

ghost commented Mar 3, 2020

Mismatched Variables

This has already been addressed in Issue #188, but #188 is closed, and it isn't fixed. On the upside this is the only issue I found in this Koan.

160 $ExpectedCount = $Properties |
161 Measure-Object |
162 Select-Object -ExpandProperty Count
163
164 $PropertyCount | Should -Be $ExpectedPropertyCount

At line 160, $ExpectedCount is initialized
A comparison is made at line 164 with $ExpectedPropertyCount

The variable needs to synchronized.
@ghost ghost added Category-Koans Invoking the Great Doubt Issue-Discussion Let's talk about it! labels Mar 3, 2020
@vexx32 vexx32 added Good First Issue ❇️ Should be quick and easy! Issue-Bug 🐛 Something's wrong! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it. and removed Issue-Discussion Let's talk about it! labels Mar 3, 2020
@vexx32
Copy link
Owner

vexx32 commented Mar 3, 2020

Good catch! Thanks for reporting this! It's a pretty quick fix, I'll see if I can get a moment to take care of it this week. If you or anyone else would like to submit a PR for it before I get to it, you're more than welcome to. 😊 💖

@Maamue Maamue mentioned this issue Mar 20, 2020
Merged
4 tasks
@Maamue
Copy link
Contributor

Maamue commented Mar 21, 2020

This issue can be closed @vexx32, apparently I mistyped the issue number and prevented it from autoclosing?

@vexx32
Copy link
Owner

vexx32 commented Mar 21, 2020

Ah yeah, I didn't see that. Thanks!

@vexx32 vexx32 closed this as completed Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category-Koans Invoking the Great Doubt Good First Issue ❇️ Should be quick and easy! Issue-Bug 🐛 Something's wrong! Up For Grabs / Hacktoberfest 💻 If it's Up For Grabs, take it and run with it! If not, ask if it's in progress / you can take it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Maamue @vexx32