Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes wrong variable used for property count #380

Merged
merged 1 commit into from
Mar 20, 2020
Merged

fixes wrong variable used for property count #380

merged 1 commit into from
Mar 20, 2020

Conversation

Maamue
Copy link
Contributor

@Maamue Maamue commented Mar 20, 2020

PR Summary

This PR fixes a mismatched variable.
$ExpectedCount was assigned a value but $ExpectedPropertyCount was queried for the value.

Fixes ##367

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • [] Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

vexx32
vexx32 approved these changes Mar 20, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this one up! 😊 💖

@vexx32 vexx32 merged commit 497abaa into vexx32:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maamue @vexx32