Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show-Karma -Meditate briefly opens a new console window #395

Closed
vexx32 opened this issue Jun 9, 2020 · 0 comments · Fixed by #397
Closed

Show-Karma -Meditate briefly opens a new console window #395

vexx32 opened this issue Jun 9, 2020 · 0 comments · Fixed by #397
Labels
Category-Module Pertaining to the module's functionality itself. Issue-Bug 🐛 Something's wrong!

Comments

@vexx32
Copy link
Owner

vexx32 commented Jun 9, 2020

Describe "Module Bug or Issue"

Calling Show-Karma -Meditate shows a console window briefly as it launches the editor in some environments.

Context "Expected Behavior"

No console window is shown unless the editor itself is a CLI application. In those cases, the application should probably launch in the current console rather than a new one.

Context "Additional Information"

Name    Version
----    -------
PSKoans 0.66.1
PSKoans 0.66.0

Name                           Value
----                           -----
PSVersion                      7.1.0-preview.3
PSEdition                      Core
GitCommitId                    7.1.0-preview.3
OS                             Darwin 19.4.0 Darwin Kernel Version 19.4.0: Wed Mar  4 22:28:40 PST 2020; root:xnu-6153.…
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@vexx32 vexx32 added Issue-Bug 🐛 Something's wrong! Category-Module Pertaining to the module's functionality itself. labels Jun 9, 2020
vexx32 added a commit that referenced this issue Jun 14, 2020
Start-Process by default opens a new console. We generally do not want
this to be the case for Show-Karma -Meditate.
vexx32 added a commit that referenced this issue Jun 14, 2020
* 🐛 (#395) Add -NoNewWindow

Start-Process by default opens a new console. We generally do not want
this to be the case for Show-Karma -Meditate.

* ✅ Update test to expect new param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Module Pertaining to the module's functionality itself. Issue-Bug 🐛 Something's wrong!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant