Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish External Help with module #319

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Publish External Help with module #319

merged 3 commits into from
Oct 30, 2019

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Oct 30, 2019 •
edited
Loading

PR Summary

At some point during CI refactoring the external help XML stopped being published with the built module and thus is missing from the nupkg on the gallery.

Context

Changes

  • Update CI and publish steps to make sure the module artefacts are published with the help XML.
  • Add a check in the publish step to verify that the help XML is present, and fail the publish step if it is not.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32
🚀 Update CI
0e504ae 
Publish built module properly
@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. Category-Build 🚀 Modifies the build / deployment system labels Oct 30, 2019
@vexx32 vexx32 requested a review from steviecoaster as a code owner October 30, 2019 17:02
@vexx32
Copy link
Owner Author

vexx32 commented Oct 30, 2019

Verified that the module artifact and nupkg artifact include the en-us help XML properly.

@vexx32 vexx32 merged commit f2d9290 into master Oct 30, 2019
@vexx32 vexx32 deleted the Help/FixHelpPublishing branch October 30, 2019 18:03
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
Category-Build 🚀 Modifies the build / deployment system Category-Module Pertaining to the module's functionality itself.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vexx32