🐛 Fix issue with verification script in katas #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckRestrictedLanguage() is far too stringent. It prevents usage of basic array indexing and member access. Switch to detecting command names in the AST. This also lets users define sub-functions if they want. Only functions defined in the test function itself will be allowed.
vexx32
added
PR-Needs-Review 🔍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
CheckRestrictedLanguage() is far too stringent. It prevents usage of basic array indexing and member access.
This PR switches to detecting command names in the AST, while still letting users define sub-functions if they want.
Only functions defined within the test function itself will be allowed.
Changes
Update $verification scriptblock with a static analysis methodology that checks for command names that would cause commands outside the function to be called and throw an error.
Checklist