Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use integers instead of strings in the -gt and -lt within the AboutComparison Koan #356

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Use integers instead of strings in the -gt and -lt within the AboutComparison Koan #356

merged 1 commit into from
Jan 29, 2020

Conversation

jschpp
Copy link
Contributor

@jschpp jschpp commented Jan 29, 2020

PR Summary

This PR should fix the misunderstanding described in #353

Context

See #353

Changes

  • Replaced array of strings with array of int
  • Added $NewArray to hold answer

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Jan 29, 2020
vexx32
vexx32 approved these changes Jan 29, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much clearer. Thank you! 😊 💖

@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Jan 29, 2020
@vexx32 vexx32 merged commit 840b69f into vexx32:master Jan 29, 2020
@jschpp jschpp deleted the fix-String-Comparison-#353 branch January 29, 2020 14:18
@jschpp jschpp mentioned this pull request Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschpp @vexx32