Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix358 - Instantiate Stings and Numbers in AboutArrays #360

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Bugfix358 - Instantiate Stings and Numbers in AboutArrays #360

merged 4 commits into from
Feb 17, 2020

Conversation

ChaseFreeman17
Copy link
Contributor

@ChaseFreeman17 ChaseFreeman17 commented Feb 17, 2020 •
edited by vexx32
Loading

PR Summary

Fixes #358

This fixes the issue where Strings and Numbers are null in the It block "allows you to check if something is contained within it" which are created in the It block before.

Context

Changes

  • Create $number and $strings in It block "allows you to check if something is contained within it"

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Feb 17, 2020
vexx32
vexx32 previously approved these changes Feb 17, 2020
View reviewed changes
Copy link
Owner

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking care of this! 💖 😊

One minor comment but everything else checks out. 🙂

@vexx32 vexx32 added PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. and removed PR-Needs-Review 🔍 Let's take a closer look! labels Feb 17, 2020
@vexx32 vexx32 removed the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label Feb 17, 2020
@vexx32 vexx32 merged commit 22de7b5 into vexx32:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees
No one assigned
Labels
Category-Koans Invoking the Great Doubt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AboutArrays Bug\Issue
2 participants
@ChaseFreeman17 @vexx32