Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Pester dependency to v4 #392

Merged
merged 1 commit into from
May 30, 2020
Merged

Pin Pester dependency to v4 #392

merged 1 commit into from
May 30, 2020

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented May 30, 2020

PR Summary

Pins the Pester version required for the module to 4.10.1 since RequiredModules doesn't appear to support a MaximumVersion, and also pins the build pipeline to maximum version of 4.99.99 for Pester.

Context

Currently users can install Pester v5 and PSKoans will be trying to utilise that version on import; this will cause things to break.

This should force PowerShellGet to retrieve the right version from the gallery when installing the new PSKoans version and avoid that breakage until I can update this module to work with v5 of Pester.

Changes

  • Set RequiredVersion in the manifest for Pester
  • Set -MaximumVersion in the CI pipeline for Pester

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Module Pertaining to the module's functionality itself. Category-Build 🚀 Modifies the build / deployment system labels May 30, 2020
@vexx32 vexx32 requested a review from steviecoaster May 30, 2020 17:14
@vexx32 vexx32 self-assigned this May 30, 2020
@vexx32 vexx32 changed the title ⬆️ Pin Pester dependency Pin Pester dependency to v4 May 30, 2020
@vexx32 vexx32 force-pushed the Build/PinPesterV4 branch from 6d632a5 to 43aa610 Compare May 30, 2020 17:56
@vexx32 vexx32 merged commit 915ea5c into master May 30, 2020
@vexx32 vexx32 deleted the Build/PinPesterV4 branch May 30, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Build 🚀 Modifies the build / deployment system Category-Module Pertaining to the module's functionality itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant