[V1][Bugfix] Skip hashing empty or None mm_data #11386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
WoosukKwon
requested review from
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
comaniac
approved these changes
Dec 20, 2024
ywang96
approved these changes
Dec 21, 2024
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: Bowen Wang <abmfy@icloud.com>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
mzusman
pushed a commit
to mzusman/vllm
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prompt["multi_modal_data"]can be None or an empty dict. In such a case, vLLM currently errors at thehash_prompt_mm_datamethod. This PR fixes the bug.I met this bug when running
benchmark_throughput.py. Not sure why this was not detected in earlier PRs.