[Build] update requirements of no-device for plugin usage #12630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
fxmarty-amd
pushed a commit
to fxmarty-amd/vllm
that referenced
this pull request
Feb 7, 2025
…ct#12630) Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com> Signed-off-by: Felix Marty <felmarty@amd.com>
ShangmingCai
pushed a commit
to ShangmingCai/vllm
that referenced
this pull request
Feb 10, 2025
…ct#12630) Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
panf2333
pushed a commit
to yottalabsai/vllm
that referenced
this pull request
Feb 18, 2025
…ct#12630) Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
kerthcet
pushed a commit
to kerthcet/vllm
that referenced
this pull request
Feb 21, 2025
…ct#12630) Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Mar 5, 2025
…ct#12630) Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com> Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar
pushed a commit
to Said-Akbar/vllm-rocm
that referenced
this pull request
Mar 7, 2025
…ct#12630) Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com> Signed-off-by: saeediy <saidakbarp@gmail.com>
qscqesze
pushed a commit
to ZZBoom/vllm
that referenced
this pull request
Mar 13, 2025
…ct#12630) Signed-off-by: Sophie du Couédic <sop@zurich.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a lot of backend devices, the requirements consists of
requirements-common.txt+ some other python packages. Therefore, when installing a plugin we first want to install vllm withrequirements-common.txtin a first step, and then installrequirements-{plugin}.txtthrough the plugin.When doing this,
VLLM_TARGET_DEVICEcannot be directly set as the name of the target device (e.g. "spyre" would raise an "Unknown runtime environment" error), therefore settingVLLM_TARGET_DEVICEasemptyis the best solution so far, but it downloads some unnecessary packages unrelated to the target device.Note: another possibility could be to add "oot" as additional accepted value for
VLLM_TARGET_DEVICE, which would installrequirements-common.txtonly.@MengqingCao tagging you because you are the last one that modified that line.
cc @youkaichao