Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update : Twitter Icon #99

Merged
merged 9 commits into from
Aug 28, 2023
Merged

Update : Twitter Icon #99

merged 9 commits into from
Aug 28, 2023

Conversation

4ndu-7h4k
Copy link
Contributor

@4ndu-7h4k 4ndu-7h4k commented Aug 9, 2023 •
edited
Loading

Updated Twitter icon

Dark Theme
image

Light Theme
image

kiaking
kiaking reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we might wanna change the file name to VTIconX.vue 👀

@4ndu-7h4k
Copy link
Contributor Author

4ndu-7h4k commented Aug 21, 2023 •
edited
Loading

Maybe we might wanna change the file name to VTIconX.vue 👀

How about VTIconTwitterX.vue ?

@4ndu-7h4k 4ndu-7h4k requested a review from kiaking August 21, 2023 06:44
@kiaking
Copy link
Member

kiaking commented Aug 21, 2023

How about VTIconTwitterX.vue?

Why? It is "X" isn't it? 👀

@4ndu-7h4k
Copy link
Contributor Author

How about VTIconTwitterX.vue?

Why? It is "X" isn't it? 👀

Yes, updated the changes.

@kiaking
Copy link
Member

kiaking commented Aug 24, 2023

Looking good to me 👍

@yyx990803 @bencodezen @NataliaTepluhina
When do you think is a good timing to ally this change...? 🤔

@Jinjiang
Copy link
Member

@kiaking I think we can merge this for now. And then we can further publish it. And then people in the docs project can choose a proper time to apply it.

Let me will check the Netlify checks failure first.

Jinjiang
Jinjiang reviewed Aug 25, 2023
View reviewed changes
src/core/components/VTSocialLink.vue Outdated
@@ -22,7 +22,7 @@ const icons = {
github: VTIconGitHub,
linkedin: VTIconLinkedIn,
slack: VTIconSlack,
twitter: VTIconTwitter,
twitter: VTIconX,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better flexibility to end users, I might prefer having both twitter and x props here. The twitter is still to the blue bird icon. The x is to the new one. So people can feel free to choose what they would like to use. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That also means we'd better keep the file src/core/components/icons/VTIconTwitter.vue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. @4ndu-7h4k Would you mind fixing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @kiaking

@Jinjiang Jinjiang merged commit 1d60731 into vuejs:main Aug 28, 2023
@4ndu-7h4k 4ndu-7h4k deleted the update-twitter-icon branch August 28, 2023 06:49
@Jinjiang Jinjiang mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jinjiang Jinjiang Jinjiang approved these changes

@kiaking kiaking Awaiting requested review from kiaking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4ndu-7h4k @kiaking @Jinjiang