docs: add a tip on using appear attribute and v-on:appear hook #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanan
requested changes
Apr 24, 2019
src/v2/guide/transitions.md
Outdated
| @@ -569,6 +569,8 @@ By default, this will use the transitions specified for entering and leaving. If | |||
|
|
|||
| and custom JavaScript hooks: | |||
|
|
|||
| <p class="tip">Both `appear` attribute and `v-on:appear` hook will cause an appear transition. Compared to `appear` attribute, `v-on:appear` hook has a higher priority. If `v-on:appear` hook is specified, using `:appear="false"` does not cancel the transition.</p> | |||
There was a problem hiding this comment.
This p.tip here breaks the flow though. Do you think you can rewrite this content in a way that doesn't require a p.tip?
There was a problem hiding this comment.
Do you think it is okay to keep p.tip but move this part below the code snippet?
There was a problem hiding this comment.
Please do heed An's advice here and rewrite it into the flow of the document. Thanks!
There was a problem hiding this comment.
I have changed the layout and removed the p.tip
DaKoala
force-pushed
the
docs-transition-appear
branch
from
10f2258 to
b908661
Compare
|
Looks good now, thanks! |
|
Hey @DaKoala, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #9320 in the issue list of vue, I added a tip to clarify the usage of
appearattribute andv-on:appearhook.