Skip to content

cli: fix local template path for windows #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

cli: fix local template path for windows #104

wants to merge 1 commit into from

Conversation

queckezz
Copy link

This PR now additionally allows windows like paths with \s

# both works now
vue init D:\dev\create-module test-project
vue init ~/dev/create-module test-project

zigomir
zigomir reviewed May 24, 2016
View reviewed changes
bin/vue-init
@@ -158,3 +158,7 @@ function downloadAndGenerate (template) {
})
})
}

function isLocal (str) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isLocal implies more than just that str is string and not an url. In my opinion exist should also be called here.

  • you can easily add test for it ;)

@zigomir zigomir self-assigned this Jul 12, 2016
@zigomir zigomir mentioned this pull request Jul 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zigomir zigomir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queckezz @zigomir