Skip to content

DOCS: replace hasProp() to props() in docs examples #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2018
Merged

DOCS: replace hasProp() to props() in docs examples #466

merged 1 commit into from
Mar 13, 2018

Conversation

iztsv
Copy link
Contributor

@iztsv iztsv commented Mar 13, 2018

Hey!

I've noticed that hasProp is deprecated:

console.error node_modules/@vue/test-utils/dist/vue-test-utils.js:15
      [vue-test-utils]: hasProp() has been deprecated and will be removed in version 1.0.0. Use props() instead—https://vue-test-utils.vuejs.org/en/api/wrapper/props

So I replaced hasProps to props in the docs.

eddyerburgh
eddyerburgh approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot. Thanks for the changes 😀

@eddyerburgh eddyerburgh merged commit cbeffec into vuejs:dev Mar 13, 2018
@iztsv
Copy link
Contributor Author

iztsv commented Mar 13, 2018 •
edited
Loading

@eddyerburgh Thanks for the reply. No problem 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iztsv @eddyerburgh