fix: method should be updated when triggering #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
May 17, 2018
| expect(wrapper.vm.isActive).to.be.true | ||
| // Replace the toggle function so that the data supposedly won't change | ||
| const toggleActive = () => console.log('overriden') | ||
| wrapper.setMethods({ toggleActive }) |
There was a problem hiding this comment.
You should trigger toggle active again after you call setMethods, to make sure it's been overwritten
There was a problem hiding this comment.
@eddyerburgh My bad, totally missed that part. I've updated the PR. Thanks.
eddyerburgh
approved these changes
May 17, 2018
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fix #615.
I've learned about this bug a while ago before the issue was raised (it happened on my project as well). Here's a small isolated repro link https://jsfiddle.net/3vbnq15z/
I understand that
updateis deprecated and the test utils are going towards synchronous updates. However I think fortriggerit is necessary to update. Let me know what you think about the approach.I also deleted one test in
setMethodspec which is a duplicate.Thanks.