Add username / password connection capabilities #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent of the default one can be used. Include tests to check the new username - password authentication.
rmarticaba
commented
Apr 8, 2024
vy
requested changes
Apr 9, 2024
There was a problem hiding this comment.
@rmarticaba, great job! I have dropped some remarks. Thanks in advance! 🙇
rmarticaba
force-pushed
the
add-username
branch
from
b60aa33 to
c1a7ca9
Compare
rmarticaba
force-pushed
the
add-username
branch
from
e478910 to
5d28bba
Compare
vy
reviewed
Apr 14, 2024
appender/src/test/java/com/vlkan/log4j2/redis/appender/RedisServerExtension.java
Outdated
Show resolved
Hide resolved
|
@rmarticaba, thanks, appreciated! I have just released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add username parameter to redis appender so connections for a user different of the default one can be used. Include tests to check the new username - password authentication.