Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially improper format for workflow createChallenge step property #455

Closed
kezike opened this issue Feb 19, 2025 · 3 comments
Closed

Potentially improper format for workflow createChallenge step property #455

kezike opened this issue Feb 19, 2025 · 3 comments
Assignees
@kezike
Labels
pr exists A Pull Request exists to address this issue.

Comments

@kezike
Copy link
Contributor

kezike commented Feb 19, 2025

I noticed that the createChallenge property in workflow.steps[STEP_NAME].createChallenge found in the workflow creation request and response as well as the workflow retrieval response is specified as a string. I believe that this should be a boolean. Is that correct?
@kezike kezike changed the title Potentially improper format for workflow createChallenge property Potentially improper format for workflow createChallenge step property Feb 19, 2025
@dlongley
Copy link
Contributor

Yes, the value of createChallenge should be a boolean.

@msporny
Copy link
Contributor

msporny commented Feb 25, 2025

The group discussed this on the 2025-02-25 call:

A PR should be raised that implements the change identified here: #455 (comment)

@msporny msporny added the ready for PR Issue ready to be resolved via a Pull Request label Feb 25, 2025
@kezike kezike mentioned this issue Mar 11, 2025
Merged
@msporny msporny added pr exists A Pull Request exists to address this issue. and removed ready for PR Issue ready to be resolved via a Pull Request labels Mar 11, 2025
@msporny
Copy link
Contributor

msporny commented Mar 11, 2025

PR #469 has been merged to address this issue.

@msporny msporny closed this as completed Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kezike kezike

Labels
pr exists A Pull Request exists to address this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msporny @dlongley @kezike