Elaborate on service configuration #443
Merged
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msporny
requested review from
BigBlueHat,
dlongley,
jandrieu,
jrhender,
eric-schuh and
PatStLouis
jrhender
reviewed
Jan 29, 2025
index.html
Outdated
Comment on lines
681
to
682
| For example, the `/credentials/issue` endpoint is expected to be at the end of a | ||
| longer URL such as `/instances/12345/credentials/issue`. In this case, it is the |
There was a problem hiding this comment.
Does it need to be at the end of longer URL? It seems reasonable to me that one could direct to specific instances in other ways. For example, one could use subdomains to address an instance or an internal service discovery mechanism.
There was a problem hiding this comment.
+1, I made a suggestion in my review.
dlongley
approved these changes
Jan 29, 2025
TallTed
suggested changes
Jan 29, 2025
Co-authored-by: John Henderson <jrhender@users.noreply.github.com> Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address issue #267 by documenting how service instance configuration works.
Fixes #267.
Preview | Diff