Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Enveloped Credentials and Enveloped Presentations #461

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

jrhender
Copy link
Contributor

@jrhender jrhender commented Feb 24, 2025

Partially addresses #424 . The objective of the PR is to add support for verifying EnvelopedVCs and EnvelopedVPs. This is done by adding enveloped VCs and VPs as possible schemas to the credentials/verify and persentations/verify endpoints respectively.

@msporny
Copy link
Contributor

msporny commented Feb 25, 2025

The group discussed this on the 2025-02-25 call and found that we do not expect application/vc or application/vp to be posted instead of application/json, but do expect oneOf the JSON Schemas listed to be used. The media type for the request will only ever be application/json with different schemas used when VCs or VPs are POSTed.

The PR needs to be updated so that the application/vc or application/vp media types aren't allowed for posting, only application/json and any of the schemas should be possible (based on the call being made).

Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoints will receive application/json always -- any use of application/vc or application/vp are not allowed (even though VCs or VPs posted inside the JSON body are allowed/expected)

@jrhender jrhender force-pushed the jrhender/424-verifying-enveloped-creds branch from 3ecf8a0 to cb03e67 Compare March 23, 2025 18:48
@jrhender
Copy link
Contributor Author

The PR needs to be updated so that the application/vc or application/vp media types aren't allowed for posting, only application/json and any of the schemas should be possible (based on the call being made).

I made this change.

@jrhender jrhender requested a review from msporny March 23, 2025 18:49
@msporny msporny merged commit 336955c into main Mar 25, 2025
1 check passed
@msporny msporny deleted the jrhender/424-verifying-enveloped-creds branch March 25, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants