Specify baseNode/baseOffset/extentNode/extentOffset? #34
Comments
|
Should I file this as a non-standard API bug still? |
|
I don't understand what you mean by "non-standard API bug". This is an issue tracker for the selection API. By definition, discussions here will be about standards API. |
|
So you are saying baseNode/baseOffset/extentNode/extentOffset are all getting standardized? Great! |
|
That is precisely what's being discussed now. To decide whether baseNode/baseOffset/extentNode/extentOffset must be standardized or not. |
|
@LoonyBean, did you file a Chromium bug to "standardize or remove" these? If so, link to this issue from here, and see if anyone comes along :) |
|
I didn't. But I certainly can.
…On Feb 15, 2017 23:02, "Philip Jägenstedt" ***@***.***> wrote:
@LoonyBean <https://github.com/LoonyBean>, did you file a Chromium bug to
"standardize or remove" these? If so, link to this issue from here, and see
if anyone comes along :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC-X4A6pEd9yA1Uh8ghmWL9b8l1dN1jpks5rc8ptgaJpZM4DGzyN>
.
|
…}{Node,Offset}
This patch makes |Selection#{base,extent}{Node,Offset}| as aliases of
|Selection#{anchor,focus}{Node,Offset}| instead of getting position from
|VisibleSelection| which we don't want to expose to JavaScript.
Note: Selection#{base,extent}{Node,Offset} are not standard API and there
are some discussion for standardizing them[1].
[1] w3c/selection-api#34
Specify baseNode/baseOffset/extentNode/extentOffset?
Bug: 701501
Change-Id: I34fcdb4e80d5cef49bc1e0bdaea3cdec5c8b3758
Reviewed-on: https://chromium-review.googlesource.com/965663
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543982}
|
I wonder how it's going. Thanks :) |
|
The current state is that these 4 attributes are in Chrome, Edge and Firefox, but not in Safari. Given that, putting them in the spec certainly seems like the least risky option. However, I'm not sure if there are important differences in behavior that would have to be sorted out. |
|
Huh? These 4 attributes are definitely in Safari since it's a WebKit extension. Did you mean Edge or Firefox instead? |
|
Yes, I mean they're in Chrome, Edge and Safari, but not Firefox. |
setBaseAndExtent as implemented in WebKit/Blink are related to these. Is the plan to drop the attributes but keep the function? Use counter data from Chrome:
https://www.chromestatus.com/metrics/feature/timeline/popularity/400
https://www.chromestatus.com/metrics/feature/timeline/popularity/401
https://www.chromestatus.com/metrics/feature/timeline/popularity/402
https://www.chromestatus.com/metrics/feature/timeline/popularity/403
https://www.chromestatus.com/metrics/feature/timeline/popularity/406
Based on this dropping the attribute looks doable, but is WebKit going to?
The text was updated successfully, but these errors were encountered: