Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redraw all structural diagrams #253

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stulacy
Copy link
Contributor

@stulacy stulacy commented Jan 3, 2024

This is an attempt to redraw the structural diagrams of all species in the MCM.
There are several benefits of doing this:

  • Force a uniform aspect ratio, as at the moment larger molecules have larger drawings. This makes it harder to draw consistent layouts and is the main reason each species page doesn't contain a large drawing of its structure
  • Use SVG allowing for simpler displaying of drawings at different sizes (i.e. small in the search box but large in each species' page)
  • Address any inconsistencies such as the crossed-bond issue mentioned in Redraw structural diagrams #181

This PR contains an initial attempt at using rdkit to achieve this in Python, and contains a comparison of the resultant drawings with those currently used. These drawings need to be assessed for their scientific accuracy as well as any aesthetic changes (reducing the pen thickness for example) before they can be incorporated into the main website.

Addresses #115 and #181

@stulacy stulacy added the enhancement New feature or request label Jan 3, 2024
Reduced bond thickness, kept atom label font size constant, and added padding
around atom labels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant