Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE 💡] Add Smooth Scrolling Through Navbar #102

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Keshav-Aneja
Copy link
Contributor

@Keshav-Aneja Keshav-Aneja commented Oct 4, 2023

Issue #95 📐

Guidelines 🔐

I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

  • Contribution Guidelines
  • Code of Conduct

Issue to be closed 🛅

The last Pull request was causing some issues, resulting in breaks between links in the cart and shoe section. So I resorted to the traditional approach for smooth scrolling. Sorry for the inconvenience caused.

Kindly Review this PR and please approve it.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nike ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 1:05pm

@github-actions github-actions bot added hacktoberfest This issue/pull request is specially marked for hacktoberfest 🐞 bug 🛠 goal: fix labels Oct 4, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Keshav-Aneja, thank you for raising a pull request.

Please make sure you have filled the PR template properly and followed our contributing guidelines.

Copy link
Owner

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warmachine028 warmachine028 added the hacktoberfest-accepted The contribution was accepted for hactoberfest label Oct 4, 2023
@warmachine028 warmachine028 merged commit 7b25dc4 into warmachine028:main Oct 4, 2023
@warmachine028 warmachine028 changed the title Fixed Smooth Scrolling [FEATURE 💡] Add Smooth Scrolling Through Navbar #95 Oct 4, 2023
@warmachine028 warmachine028 changed the title [FEATURE 💡] Add Smooth Scrolling Through Navbar #95 [FEATURE 💡] Add Smooth Scrolling Through Navbar Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature ⭐ goal: addition hacktoberfest This issue/pull request is specially marked for hacktoberfest hacktoberfest-accepted The contribution was accepted for hactoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE 💡] Add Smooth Scrolling Through Navbar
2 participants