Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX 🛠️] Shift in Page when select option of Navbar #106

Merged

Conversation

abdulrehmanjaved-1
Copy link
Contributor

@abdulrehmanjaved-1 abdulrehmanjaved-1 commented Oct 4, 2023

Issue #101 📐

Guidelines 🔐

I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

  • Contribution Guidelines
  • Code of Conduct

Issue to be closed 🛅

Screenshots 📷

Here are the pictures of changes that I have made 🔽
Screenshot from 2023-10-05 13-07-33


@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nike ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:14am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @abdulrehmanjaved-1, thank you for raising a pull request.

Please make sure you have filled the PR template properly and followed our contributing guidelines.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations 🎉 @abdulrehmanjaved-1, on your first contribution in Nike

  • Make sure to star this project, if you liked contributing to it. 🌟🌟🌟
  • You can raise another new issue, if you find something is worth enhancement or needs a fix.
  • You can see my other projects too, which you might feel appealing.
  • You also follow me for making more future contributions in open-source projects.

Copy link
Owner

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete the PR template
Add the issue name as The PR title
Change BUG 🐞 to FIX 🛠️, refer closed PR titles

@abdulrehmanjaved-1
Copy link
Contributor Author

ah okay

@abdulrehmanjaved-1
Copy link
Contributor Author

making it again

@warmachine028
Copy link
Owner

No need to close this PR, you can copy the template from .GitHub directory only

@abdulrehmanjaved-1 abdulrehmanjaved-1 changed the title fix: fixed default behaviour of navigation [FIX 🛠️] Shift in Page when select option of Navbar #101 Oct 4, 2023
@warmachine028
Copy link
Owner

The PR template is not valid

@abdulrehmanjaved-1
Copy link
Contributor Author

Can you tell where is .GitHub directory?

@warmachine028
Copy link
Owner

Can you tell where is .GitHub directory?

Here

@abdulrehmanjaved-1
Copy link
Contributor Author

now?

@warmachine028 warmachine028 changed the title [FIX 🛠️] Shift in Page when select option of Navbar #101 [FIX 🛠️] Shift in Page when select option of Navbar Oct 5, 2023
warmachine028

This comment was marked as duplicate.

Copy link
Owner

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Screenshots of the UI where the changes are made, not the Code

@abdulrehmanjaved-1
Copy link
Contributor Author

Done

@warmachine028 warmachine028 merged commit 8e9e4a5 into warmachine028:main Oct 5, 2023
@warmachine028 warmachine028 added the hacktoberfest-accepted The contribution was accepted for hactoberfest label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug 🛠 goal: fix hacktoberfest This issue/pull request is specially marked for hacktoberfest hacktoberfest-accepted The contribution was accepted for hactoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift in Page when select option of Navbar
2 participants