[FIX 🛠️] Cart Add or Subtract Item #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
hacktoberfest
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @shoaib-31, thank you for raising a pull request.
Please make sure you have filled the PR template properly and followed our contributing guidelines.
warmachine028
requested changes
Oct 20, 2023
There was a problem hiding this comment.
@shoaib-31 Great work here, I would suggest just a minor change.
- Add a Trash icon to remove the item from cart
- And don't allow user to go below 1 qty and above 10 qty.
|
@warmachine028 Is it right position of trash can? video.webm |
Absolutely, great work |
warmachine028
approved these changes
Oct 20, 2023
warmachine028
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #171 📐
Guidelines 🔐
I accept the fact that I have followed the guidelines and have not copied the codes from around the internet
Issue to be closed 🛅
Screenshots 📷
Here are the pictures of changes that I have made 🔽
video.webm