This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Version 4.x does not fire connected event for subscriptions.
#6252
Assignees
Labels
Comments
17 tasks
Muhammad-Altabba
added a commit
that referenced
this issue
Jul 14, 2023
* enable custom subscription * refactor to simplify the inheritance from Web3Subscription * add `CombinedEventMap` type to `Web3Subscription` * remove unneeded casting inside `_buildSubscriptionParams` * add a test * fix "Version 4.x does not fire connected event for subscriptions. #6252" * update CHANGELOG.md files
sanyu1225
pushed a commit
to blocto/web3.js
that referenced
this issue
Aug 30, 2023
* enable custom subscription * refactor to simplify the inheritance from Web3Subscription * add `CombinedEventMap` type to `Web3Subscription` * remove unneeded casting inside `_buildSubscriptionParams` * add a test * fix "Version 4.x does not fire connected event for subscriptions. web3#6252" * update CHANGELOG.md files
sanyu1225
pushed a commit
to blocto/web3.js
that referenced
this issue
Aug 30, 2023
* enable custom subscription * refactor to simplify the inheritance from Web3Subscription * add `CombinedEventMap` type to `Web3Subscription` * remove unneeded casting inside `_buildSubscriptionParams` * add a test * fix "Version 4.x does not fire connected event for subscriptions. web3#6252" * update CHANGELOG.md files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
According to 1.x documentation https://web3js.readthedocs.io/en/v1.2.11/web3-eth-subscribe.html there should be an event called
connectedthat fires once after the subscription is successfully connected and should return the subscription id.But version 4.x does not implement that.
However, it is mentioned as a number. But should be a string. As the subscription id used in version 4.x is a string.
The text was updated successfully, but these errors were encountered: