Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix accessing event.name where event is undefined #3015

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

micahriggan
Copy link
Contributor

closes #3014

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@micahriggan micahriggan force-pushed the fix/web3-contract-event-name branch from 5a65aec to ba00dba Compare August 8, 2019 15:14
@nivida nivida added 1.x 1.0 related issues Bug Addressing a bug In Progress Currently being worked on labels Aug 8, 2019
@micahriggan micahriggan force-pushed the fix/web3-contract-event-name branch 2 times, most recently from 008f4de to 87ab9ab Compare August 8, 2019 16:00
@micahriggan
Copy link
Contributor Author

@nivida any tips for the The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during . issue with travis? Did I do something wrong?

@micahriggan micahriggan force-pushed the fix/web3-contract-event-name branch from 87ab9ab to ba00dba Compare August 8, 2019 16:04
@nivida
Copy link
Contributor

nivida commented Aug 8, 2019

@micahriggan Yes, the fix would be to add xvfb as service as described here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 83.191% when pulling 1683f20 on micahriggan:fix/web3-contract-event-name into 2022b17 on ethereum:1.x.

@nivida nivida removed the In Progress Currently being worked on label Aug 9, 2019
@nivida nivida merged commit 2d0a3f3 into web3:1.x Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants