This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
create a new type Eip1193Compatible
#6407
Merged
Muhammad-Altabba
merged 6 commits into
4.x
from
6345-the-returned-value-of-request-method-at-the-providers-does-not-comply-with-eip-1193
Sep 12, 2023
Merged
create a new type Eip1193Compatible
#6407
Muhammad-Altabba
merged 6 commits into
4.x
from
6345-the-returned-value-of-request-method-at-the-providers-does-not-comply-with-eip-1193
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6407 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 199 199
Lines 7723 7723
Branches 2128 2128
=======================================
Hits 6882 6882
Misses 841 841
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with
|
Latest commit: |
850adca
|
Status: | ✅ Deploy successful! |
Preview URL: | https://8aa700e0.web3-js-docs.pages.dev |
Branch Preview URL: | https://6345-the-returned-value-of-r.web3-js-docs.pages.dev |
jdevcs
reviewed
Sep 7, 2023
jdevcs
reviewed
Sep 7, 2023
…the-providers-does-not-comply-with-eip-1193
luu-alex
approved these changes
Sep 8, 2023
Eip1193FullyCompatible
Eip1193Compatible
jdevcs
approved these changes
Sep 11, 2023
avkos
approved these changes
Sep 11, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6345 by allowing the user to get an instance of any Web3 Provider that has the returned value of
request
fully compatible with EIP-1193.Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.