This repository was archived by the owner on Mar 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 18ae7ff | Previous: 51d216f | Ratio |
---|---|---|---|
processingTx |
8900 ops/sec (±5.17% ) |
9224 ops/sec (±3.84% ) |
1.04 |
processingContractDeploy |
39103 ops/sec (±8.96% ) |
41118 ops/sec (±7.75% ) |
1.05 |
processingContractMethodSend |
18797 ops/sec (±8.21% ) |
20556 ops/sec (±6.13% ) |
1.09 |
processingContractMethodCall |
37691 ops/sec (±6.31% ) |
41085 ops/sec (±4.96% ) |
1.09 |
abiEncode |
42988 ops/sec (±7.14% ) |
46586 ops/sec (±6.55% ) |
1.08 |
abiDecode |
28552 ops/sec (±8.76% ) |
31710 ops/sec (±6.85% ) |
1.11 |
sign |
1556 ops/sec (±0.92% ) |
1608 ops/sec (±0.76% ) |
1.03 |
verify |
357 ops/sec (±2.90% ) |
374 ops/sec (±2.89% ) |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
jdevcs
approved these changes
Jun 4, 2024
avkos
approved these changes
Jun 4, 2024
This was referenced Jul 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6234
Wasn't able to reproduce gas estimation error, but was able to fix another issue with serializing bigInt.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.