Skip to content

BIP39.mnemonicsToEntropy does not work for mnemonics of length 15, 18, 21 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sche opened this issue Jan 7, 2021 · 2 comments · Fixed by #301
Closed

BIP39.mnemonicsToEntropy does not work for mnemonics of length 15, 18, 21 #300

sche opened this issue Jan 7, 2021 · 2 comments · Fixed by #301
Labels
enhancement New feature or request

Comments

@sche
Copy link
Contributor

sche commented Jan 7, 2021

Because of the check in code wordList.count.isMultiple(of: 4) here https://github.com/matter-labs/web3swift/blob/a4e4985c9ef97892ba56d78e9249f2485b262d1b/Sources/web3swift/KeystoreManager/BIP39.swift#L117 it does not work.
It should be multiple of 3.
@sche sche mentioned this issue Jan 7, 2021
Merged
@skywinder skywinder added the enhancement New feature or request label Jul 31, 2021
@skywinder
Copy link
Collaborator

thanks, @sche ! We will merge it in the next release!

sche added a commit to sche/web3swift that referenced this issue Aug 6, 2021
@sche
Merge branch 'develop' of https://github.com/skywinder/web3swift into w…
2f36972 
…eb3swift-teamgh-300-fix-mnemonic-check
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 30.0 DAI (30.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @sche.

TonioMacaronio added a commit that referenced this issue Oct 29, 2021
@TonioMacaronio
Merge pull request #301 from sche/gh-300-fix-mnemonic-check
22db259 
fix mnemonicsToEntropy mnemonic length check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix mnemonicsToEntropy mnemonic length check sche/web3swift
4 participants
@sche @skywinder @gitcoinbot @TonioMacaronio