fix-2239 : Add webpack@5 in CI #2320
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffin143
requested review from
alexander-akait,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2320 +/- ##
=======================================
Coverage 93.92% 93.92%
=======================================
Files 34 34
Lines 1284 1284
Branches 366 366
=======================================
Hits 1206 1206
Misses 77 77
Partials 1 1Continue to review full report at Codecov.
|
|
Sorry, I am not sure which version to follow/checkout, The tests are failing for webpack@5 |
| @@ -50,6 +50,9 @@ jobs: | |||
| node-6: | |||
| node_version: ^6.9.0 | |||
| webpack_version: latest | |||
| webpack-new: | |||
| node_version: ^10.13.0 | |||
| webpack_version: 5.0.0-alpha.26 | |||
There was a problem hiding this comment.
Sorry , but I just found out this pr is same as #2244, since the issue was not tagged from other pr , I end up making a pr .
I will go ahead and close it :).
Thanks for your time
alexander-akait
requested changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
NA
Motivation / Use-Case
Handling : #2239, @evilebottnawi : I tried setting up CI for webpack@5 according to #2239 (comment)
Breaking Changes
NA
Additional Info
NA