-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-export rtcp/rtp/interceptor/data/media #125
Conversation
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 57.67% 57.70% +0.03%
==========================================
Files 68 68
Lines 5533 5533
Branches 1696 1698 +2
==========================================
+ Hits 3191 3193 +2
+ Misses 855 854 -1
+ Partials 1487 1486 -1
Continue to review full report at Codecov.
|
@@ -12,6 +12,9 @@ pub mod stats; | |||
pub mod util; | |||
|
|||
pub use error::Error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to examples’ Cargo.toml, let’s re-export data and media too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 👍
There are name confict for |
src/lib.rs
Outdated
@@ -11,7 +11,12 @@ pub mod peer; | |||
pub mod stats; | |||
pub mod util; | |||
|
|||
pub use ::data as _data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use webrtc_data and webrtc_media?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
can these re-export solve version mismatch issue? Have you tried it in examples crate? |
yep, this will reduce the manually version tagging for subcrates. |
@wdv4758h, I just upgrade webrtc crate to v0.2.2 with this PR. Could you submit a PR for examples crate with this change? |
yep |
I'm building SFU based on WebRTC.rs. And I feel adding related dependencies in my Cargo.toml is a bit inconvenient. There is potential of version mismatch problem. So I think re-export dependencies under
webrtc
crate might help. (not sure if I should re-export all of them though)