Skip to content

Add room member #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 18, 2021
Merged

Add room member #127

merged 25 commits into from
Mar 18, 2021

Conversation

su-chang
Copy link
Member

@su-chang su-chang commented Mar 9, 2021

No description provided.

su-chang and others added 6 commits May 8, 2020 14:42
* upgrade grpc to compatible with Go

* fix: correct the spell mistake for accept friendship

* refactor

* 0.7.3

* modify: upgrade @chatie/grpc

* add GRPC keepalive timeout doc link

* fix typing

* 0.7.4

* add performance test, to be fixed

* add performance test and skip it

* 0.7.5

* fix typo

* 0.7.6

* fix typo (wechaty#35)

* 0.7.7

Co-authored-by: Huan LI <zixia@zixia.net>
@su-chang su-chang requested a review from windmemory March 10, 2021 02:40
windmemory
windmemory previously approved these changes Mar 10, 2021
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved!

@su-chang su-chang requested a review from windmemory March 12, 2021 02:44
windmemory
windmemory previously approved these changes Mar 18, 2021
windmemory
windmemory previously approved these changes Mar 18, 2021
@su-chang su-chang requested a review from huan March 18, 2021 07:41
windmemory
windmemory previously approved these changes Mar 18, 2021
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan
Copy link
Member

huan commented Mar 18, 2021

Thank you very much for adding this great new feature to our Wechaty ecosystem, appreciate it!

@huan huan merged commit d216c2b into wechaty:master Mar 18, 2021
@su-chang su-chang deleted the add-room-member branch April 28, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants