Additional Left/Right Modifiers + Win #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d right modifiers into specific variants
|
I'm gonna take a look at this. Somehow GitHub is not sending to me all the notifications from this repository and I did not see this PR |
|
This looks fine to me. I will test these, and either merge this right away, or try to add these modifiers at least on the Linux/X side myself |
|
I'm happy with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Only affects Win32KeyBoard, as I'm unfamiliar with how to make similar changes in the other keyboards.
With left and/or right modifiers active, the combined modifier is also active. Both left/right must be inactive for the combined modifier to deactivate. This should only affect client code if they are comparing the entire bit field. However, the function to return the full bit field did not exist before this pull request.